Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workgroups for Python #116

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Conversation

alexander-g
Copy link
Contributor

  • bugfix for custom workgroups in C++ (OpAlgoBase.cpp:28)
  • added workgroup argument for Sequence.record_algo* + test case
  • Merged both Tensor constructors and it now also accepts numpy arrays

python/src/main.cpp Outdated Show resolved Hide resolved
Copy link
Member

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alexander-g ! Added a couple of comments

@alexander-g
Copy link
Contributor Author

By the way, work group is optional but you might consider making it a required argument because the default is a poor choice. It creates a work group for each value of the first tensor which is usually very inefficient. Instead one should choose a low number of work groups and increase the number of threads per work group e.g. in GLSL: layout (local_size_x = 32) in; to make full use of the GPU's parallel architecture

@axsaucedo
Copy link
Member

Hmmm that is a good point @alexander-g. I think the default is primarily to enable less experienced users to get started with the simpler examples, but I agree that most times in produciton you'd expect people to explicitly provide these.

@axsaucedo axsaucedo self-requested a review January 18, 2021 18:48
@axsaucedo axsaucedo merged commit 661a50e into KomputeProject:master Jan 18, 2021
@axsaucedo axsaucedo added bug Something isn't working enhancement New feature or request labels Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants